Locked History Actions

OSGeoIncubationCodeProvenance_iGeoPortal

Code copyright review for 'apps/iGeoPortal_standard' module

All files have been reviewed. Open issues are listet below.

1. Review Status

First review (determin problematic files / add missing headers to flawless files) finished for:

  • doc/*
  • help/*
  • javascript/*
  • modules/csw/*
  • module/digitizer/*
  • module/gazetteer/*
  • module/mapeditor/*
  • module/pdfprint/*
  • module/timeselect/*
  • module/wpsvclient/*
  • main folder
  • WEB-INF/classes/*
  • WEB-INF/conf/*

What about ... ?

  • css/deegree*.css
  • images/*
  • module/*/images/*
  • WEB-INF/lib/*

Second review (solving open issues) finished on 2009-10-20, SVN revision #20230.

Affected Files:

  • javascript/request_handler.js

Header Example:

no header available

Action:

  • add header. (./) done (SVN revision #20230)

3. [SOLVED] Files with references to http://www.JSON.org/json2.js

Affected Files:

  • javascript/jason2.js

Header Example:

/*
    http://www.JSON.org/json2.js
    2008-07-15

    Public Domain.

    NO WARRANTY EXPRESSED OR IMPLIED. USE AT YOUR OWN RISK.

    See http://www.JSON.org/js.html

    [...]

    This is a reference implementation. You are free to copy, modify, or
    redistribute.

    This code should be minified before deployment.
    See http://javascript.crockford.com/jsmin.html

    USE YOUR OWN COPY. IT IS EXTREMELY UNWISE TO LOAD CODE FROM SERVERS YOU DO
    NOT CONTROL.
*/

Action:

  • leave as is. (./) done

4. [SOLVED] Files with reference to grit GmbH

Affected Files:

  • javascript/wktadapter.js
  • javascript/rendering.js (no header. according to AP)
  • javascript/geometryfactory.js (no header. according to AP)

Header Example:

/** This notice must be untouched at all times.

Copyright (C) 2008 lat/lon GmbH
poth@lat/lon.de
http://www.lat-lon.de

bases on a javascript object written by Florian Rengers / grit GmbH:

Copyright (C) 2005  author: Florian Rengers / grit GmbH

contact:
florian.rengers@web.de
http://www.grit.de


LICENSE: LGPL

This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.

This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Lesser General Public License for more details.

You should have received a copy of the GNU Lesser General Public
License along with this library; if not, write to the Free Software
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA,
or see http://www.gnu.org/copyleft/lesser.html
*/

Action:

  • use new standard header with addendum for third-party contribution (./) done (SVN revision #20230)

5. [SOLVED] Files with reference to Eric Krock

Affected Files:

  • javascript/validation.js

Header Example:

// validation.js
//
// taken from http://doc.async.com.br/formcheck_re/overview.html
// U.S. specific checks has been removed
//
// [...]
//
// 18 Feb 97 created Eric Krock
// Original JavaScript 1.0-only version (works on Nav2.x and higher)
// available at http://developer.netscape.com/library/examples/javascript/formval/overview.html
//
// 4 Nov 97 rewritten to demonstrate use of JavaScript 1.2 regular expressions.
// (code is simpler and shorter but works on Nav4.x and higher only)
//
// (c) 1997 Netscape Communications Corporation

Action:

  • leave as is. (./) done

6. [SOLVED] Files with reference to CodeThat

Affected Files:

  • modules/timeselect/codethatcalendarstd.zip
  • modules/timeselect/codethatcalendarstd.js
  • modules/timeselect/codethatcalendar.html
  • modules/timeselect/scroller_ex.js
  • css/ctc.css
  • css/ctcstd.css
  • css/s.css

Header Example:

// CodeThatCalendar STANDARD
// Version: 3.2.1 (02.14.2006.1)
// THE SCRIPT IS FREE FOR NON-COMMERCIAL AND COMMERCIAL USE.
// Copyright (c) 2003-2006 by CodeThat.Com
// http://www.codethat.com/

Action:

  • leave as is. (./) done

7. [SOLVED] Files with reference to Walter Zorn

Affected Files:

  • javascript/wz_jsgraphics.js
  • module/wpvsclient/js/wz_jsgraphics.js
  • module/wpvsclient/js/wz_jsgraphics_box.js (no header. matches wz_jsgraphics.js very closely. older version of same file?)

Header Example:

/* This notice must be untouched at all times.

wz_jsgraphics.js    v. 2.3
The latest version is available at
http://www.walterzorn.com
or http://www.devira.com
or http://www.walterzorn.de

Copyright (c) 2002-2004 Walter Zorn. All rights reserved.
Created 3. 11. 2002 by Walter Zorn (Web: http://www.walterzorn.com )
Last modified: 17. 5. 2004

Performance optimizations for Internet Explorer
by Thomas Frank and John Holdsworth.
fillPolygon method implemented by Matthieu Haller.

High Performance JavaScript Graphics Library.
Provides methods
- to draw lines, rectangles, ellipses, polygons
  with specifiable line thickness,
- to fill rectangles and ellipses
- to draw text.
NOTE: Operations, functions and branching have rather been optimized
to efficiency and speed than to shortness of source code.

This program is free software;
you can redistribute it and/or modify it under the terms of the
GNU General Public License as published by the Free Software Foundation;
either version 2 of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY;
without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
See the GNU General Public License
at http://www.gnu.org/copyleft/gpl.html for more details.
*/

Action:

  • updated to version 3.05 of the wz library, as this is published under LGPL.
    • done for iGeoPortal (portlet edition)
    • done for iGeoPortal (standard edition)
      • deleted wz_jsgraphics_box.js and any reference to this file
    • done for wpvsclient inside iGeoPortal standard edition
  • solved for SVN revision #19854


CategoryDeegreeOrganisation CategoryDeegree2