Unterhaltung mit #deegree

(14:28:39) Das Thema für #deegree ist: Welcome to deegree, an OSGeo project. Visit the main project page at http://deegree.org and our wiki at http://wiki.deegree.org with lots of extra info. Check out a running system at http://demo.deegree.org and follow us on twitter @deegree_org.
(14:29:36) markusschneider: hi guys.
(14:29:39) copierrj: hi
(14:29:50) markusschneider: torsten is not available, so i guess we can start.
(14:29:59) copierrj: ok
(14:30:18) markusschneider: stephan, you're ready?
(14:30:58) StephanR: hi
(14:31:14) markusschneider: Agenda: http://wiki.deegree.org/deegreeWiki/TmcMeeting/TmcMeeting2014060
(14:31:28) markusschneider: just pull requests so far. would you like to add something?
(14:31:43) copierrj: "This page does not exist yet. You can create a new empty page, or use one of the page templates."
(14:32:00) copierrj: should be http://wiki.deegree.org/deegreeWiki/TmcMeeting/TmcMeeting20140606
(14:32:05) markusschneider: right, sorry
(14:32:24) copierrj: only pulls is fine with me
(14:32:44) markusschneider: great. let's start with the 3.4 pulls then
(14:33:02) markusschneider: https://github.com/deegree/deegree3/pull/204
(14:33:17) markusschneider: we had that one already several times...
(14:33:33) copierrj: requires probably f2f discussion
(14:33:51) markusschneider: or at least mailing list discussion
(14:34:35) markusschneider: i suggest to add to the ticket that this requires a discussion on the mailing list
(14:34:47) markusschneider: ok?
(14:35:00) copierrj: we should have an overall architecture discussion someday
(14:35:12) copierrj: ticket is fine with me
(14:35:15) StephanR: i think that is ok
(14:35:21) markusschneider: i totally agree...
(14:35:29) markusschneider: but when and where?
(14:35:36) copierrj: the f2f meeting in july
(14:35:51) markusschneider: will be more about organizational stuff
(14:35:52) copierrj: if it's not going to be postponed again...
(14:36:12) markusschneider: would you like to put the layer redesign onto the agenda?
(14:36:29) copierrj: yes, among other things
(14:37:09) markusschneider: i believe there was a list of agenda proposals for the f2f meeting!?
(14:37:10) copierrj: we could try to do that on the mailinglist of course
(14:37:49) markusschneider: you mean the redesign discussion?
(14:38:05) copierrj: yes
(14:38:08) markusschneider: i would be in favor to start this with a personal discussion
(14:38:24) markusschneider: i believe it will be more effective
(14:38:43) markusschneider: i second to put this on the agenda.
(14:38:47) copierrj: we could try to squeeze it in somehow in the next f2f meeting?
(14:39:14) markusschneider: or at least make a point that we need a separate meeting for that
(14:39:20) copierrj: right
(14:39:25) copierrj: perhaps tmc only?
(14:39:29) markusschneider: yes
(14:39:35) StephanR: yes
(14:39:39) markusschneider: + interested developers
(14:39:51) copierrj: let's discuss this in july @bonn
(14:40:31) markusschneider: we could see if the FOSS4G-Europe 2014 Code Sprint is a good opportunity for this!?
(14:40:52) copierrj: when is that going to happen?
(14:40:54) markusschneider: if you agree, i will answer to torsten's email
(14:40:58) markusschneider: http://wiki.osgeo.org/wiki/FOSS4G-Europe_2014_Code_Sprint
(14:41:13) markusschneider: Friday 18th July
(14:41:32) markusschneider: bremen
(14:42:22) markusschneider: well, i will answer and then we see what happens. ok?
(14:42:31) copierrj: hmm, bremen is not exactly in my neighbourhood...
(14:42:41) markusschneider: of course we all have to check our availability...
(14:42:43) markusschneider: ok
(14:42:46) copierrj: sure
(14:42:56) markusschneider: then this is the right opportunity to propose alternatives
(14:43:24) markusschneider: anyway, can we get back to the pull request?
(14:43:28) copierrj: ok
(14:43:37) markusschneider: your votes on merging #204
(14:43:40) markusschneider: -1
(14:44:07) copierrj: -1 (for now)
(14:44:12) StephanR: -1
(14:44:25) markusschneider: Result: -3. Not merging (for now).
(14:44:46) markusschneider: https://github.com/deegree/deegree3/pull/209
(14:45:15) markusschneider: reijer, your comment is from May 7th. when are we going to close this
(14:45:58) copierrj: now?
(14:45:59) markusschneider: i suggest to close pull requests after 3 months, if author does not respond
(14:46:06) markusschneider: to have a general rule
(14:46:10) markusschneider: too long?
(14:46:11) copierrj: do we know the author of this pull?
(14:46:14) markusschneider: sure
(14:46:21) copierrj: could we poke him?
(14:46:36) markusschneider: yeah, by simply adding another comment
(14:46:46) copierrj: obviosly that didn't work...
(14:46:47) markusschneider: that this going to be closed in 2 months
(14:46:56) copierrj: that's fine with me
(14:47:17) markusschneider: can we make quick vote on the proposal of a general 3 month timeout?
(14:47:21) markusschneider: +1
(14:47:28) copierrj: +1
(14:47:28) StephanR: +1
(14:47:39) markusschneider: +3. Motion accepted.
(14:47:44) markusschneider: I will add that to the wiki
(14:47:51) copierrj: great!
(14:47:54) markusschneider: https://github.com/deegree/deegree3/pull/211
(14:48:02) markusschneider: -1 (same)
(14:48:16) copierrj: -1
(14:48:20) StephanR: -1
(14:48:26) markusschneider: -3. Not merging (for now)
(14:48:39) markusschneider: https://github.com/deegree/deegree3/pull/213
(14:48:42) markusschneider: -1 (same)
(14:49:07) copierrj: -1 (3.4 pull is missing)
(14:49:15) StephanR: -1
(14:49:19) markusschneider: and it doesn't compile...
(14:49:43) markusschneider: -3. Not merging (for now)
(14:49:48) markusschneider: https://github.com/deegree/deegree3/pull/215
(14:50:01) markusschneider: -1
(14:51:27) copierrj: i don't understand the issue it's supposed to fix
(14:51:35) copierrj: -1 (ci failure)
(14:51:43) markusschneider: was a timeout...
(14:51:47) markusschneider: just restarted it
(14:52:02) copierrj: postpone this pull?
(14:52:23) markusschneider: stephan?
(14:52:26) markusschneider: ok by me
(14:53:00) markusschneider: stephan, do you read?
(14:53:07) StephanR: ok, lets see if the build will work next time
(14:53:11) markusschneider: good
(14:53:12) markusschneider: https://github.com/deegree/deegree3/pull/249
(14:53:20) markusschneider: +1
(14:53:31) copierrj: +1
(14:53:58) StephanR: 0
(14:54:16) markusschneider: out of curiosity: why?
(14:54:20) markusschneider: +2. merging
(14:54:52) markusschneider: i tried to do everything "by the book"
(14:54:58) markusschneider: even discussed that on the ml...
(14:55:07) markusschneider: so how would i get your vote?
(14:55:42) markusschneider: never mind. it's totally fine. just curious.
(14:55:44) markusschneider: https://github.com/deegree/deegree3/pull/250
(14:55:58) copierrj: +1
(14:56:00) markusschneider: +1
(14:56:10) StephanR: that 0 ist not meant to critize the pull, i do not have the overview about the gdal stuff
(14:56:15) markusschneider: ok
(14:56:28) markusschneider: that's totally alright
(14:57:01) StephanR: +1
(14:57:15) markusschneider: +3. Merging.
(14:57:44) markusschneider: https://github.com/deegree/deegree3/pull/301
(14:58:14) markusschneider: +1
(14:58:19) copierrj: +1
(14:58:23) StephanR: +1
(14:58:29) markusschneider: +3. Merging.
(14:58:51) markusschneider: https://github.com/deegree/deegree3/pull/300
(15:01:40) copierrj: code looks fine, could potentially break existing configs
(15:02:13) markusschneider: what do you have in mind?
(15:02:37) markusschneider: if people have been using quotes already?
(15:02:56) markusschneider: as far as i understand, such configs never worked correctly...
(15:03:00) copierrj: we change to configuration semantics: requires integration tests
(15:03:13) copierrj: just to be sure
(15:03:36) markusschneider: ok, i totally appreciate better tests
(15:03:45) markusschneider: can you respond with ideas for improvement?
(15:03:53) markusschneider: to the ticket
(15:04:06) copierrj: it is not something we should implement in code
(15:04:22) markusschneider: no?
(15:04:26) copierrj: we should just test exististing comcplicated configs
(15:04:46) markusschneider: what do you mean by complicated?
(15:05:28) copierrj: large configs utilizing many features of the sql feature store
(15:05:50) markusschneider: hm
(15:06:08) markusschneider: i see your point
(15:06:27) markusschneider: do you have any concrete ideas how to go about this pull request?
(15:06:50) copierrj: 0) ask dev about his test results
(15:06:53) copierrj: 1) do our own tests
(15:07:05) markusschneider: ok.
(15:07:14) copierrj: we could just merge
(15:07:21) copierrj: it's only going into master (= test releases)
(15:07:25) markusschneider: maybe we should think about problematic cases and add them to the pull request
(15:07:29) markusschneider: no, it's also for 3.3
(15:07:44) copierrj: yes, but i would like to suggest to be carefull with the 3.3 one
(15:07:57) copierrj: we could be somewhat less carefull for master
(15:08:29) markusschneider: so accept for 3.4, deny for 3.3
(15:08:37) copierrj: but i still think that some of us should give it a try
(15:08:53) markusschneider: yeah, that would be good
(15:08:58) copierrj: we do have quite some configs laying around...
(15:09:05) markusschneider: however, i don't know when i do find the time for this
(15:09:16) copierrj: same here unrfortunately
(15:09:39) markusschneider: there's actually something that looks fishy to me
(15:09:51) markusschneider: the first change here:
(15:09:51) markusschneider: https://github.com/deegree/deegree3/pull/300/files
(15:10:10) markusschneider: at least the error message is wrong
(15:10:54) markusschneider: ok, i change my vote to -1 for now
(15:11:06) copierrj: -1 (needs additional testing)
(15:11:29) copierrj: we should add an appropriate comment to the pull
(15:11:41) StephanR: 0
(15:11:58) markusschneider: yes, please help me out. but i will also try to look into it
(15:12:08) markusschneider: -2. not merging (for now)
(15:12:11) copierrj: suggestion:
(15:12:51) copierrj: something like: good work, needs additional testing on existing configs
(15:12:59) markusschneider: ok
(15:13:06) StephanR: as a side question: does the ull 300 only includes the 3 changed files ?
(15:13:19) markusschneider: yes
(15:13:59) markusschneider: sorry, can we speed up a bit?
(15:14:02) copierrj: i'll post a comment
(15:14:05) markusschneider: thx
(15:14:18) markusschneider: https://github.com/deegree/deegree3/pull/299
(15:14:35) markusschneider: -1 (for now, see my comments)
(15:17:45) copierrj: comment posted
(15:18:20) markusschneider: oh, you did that right away
(15:18:21) markusschneider: thx
(15:18:28) copierrj: -1
(15:18:36) markusschneider: stephan?
(15:18:43) StephanR: -1 (because of the missing pull for 3.3)
(15:18:57) copierrj: we could do our own 3.3 rebase
(15:19:08) markusschneider: -3. not merging (for now)
(15:19:17) markusschneider: https://github.com/deegree/deegree3/pull/289
(15:19:39) copierrj: waiting for expert opinion
(15:20:18) markusschneider: so, stephan, do you still see the cance to perform a deeper analysis?
(15:20:53) StephanR: we could merge this into the code (@copierrj i had still no time to look deeper into it, but i could do this afterwards)
(15:21:07) markusschneider: ok, is 3.4-only anyway
(15:21:08) markusschneider: +1
(15:21:11) copierrj: +1
(15:21:14) StephanR: so it would be ok for me to merge this one, as you are waiting for it
(15:21:19) StephanR: +1
(15:21:28) markusschneider: +3. merged
(15:21:36) copierrj: perhaps we should also do a 3.3 backport someday
(15:21:57) markusschneider: i would rather get 3.4 out...
(15:22:02) copierrj: me2
(15:22:15) markusschneider: https://github.com/deegree/deegree3/pull/304
(15:22:37) markusschneider: +1
(15:22:41) copierrj: +1
(15:22:47) StephanR: +1
(15:22:59) markusschneider: +3. Merged
(15:23:25) markusschneider: ok. 3.3 pulls now
(15:23:41) markusschneider: https://github.com/deegree/deegree3/pull/220
(15:23:58) markusschneider: this is already in 3.4, right?
(15:24:00) copierrj: +1 (3.4 accepted earlier)
(15:24:04) markusschneider: +1
(15:24:19) StephanR: +1
(15:24:22) copierrj: this one for 3.3 had ci problems
(15:24:26) markusschneider: +1. Merging
(15:24:48) markusschneider: sorry, forgot a 3.4 pull
(15:24:55) markusschneider: https://github.com/deegree/deegree3/pull/285
(15:25:03) copierrj: +1
(15:25:06) markusschneider: +1
(15:25:11) StephanR: +1
(15:25:24) markusschneider: +3. Merging
(15:25:29) copierrj: future idea: return Set<Particle>
(15:25:56) copierrj: i like extension points like this one
(15:26:49) markusschneider: https://github.com/deegree/deegree3/pull/229
(15:26:55) markusschneider: -1 (3.4 missing)
(15:27:18) copierrj: 3.4 has the same problem?
(15:27:31) markusschneider: i believe
(15:27:36) markusschneider: we should check
(15:28:06) copierrj: for now: -1
(15:28:38) markusschneider: stephan?
(15:28:52) StephanR: -1
(15:28:56) markusschneider: -3. Not merging (for now)
(15:29:03) markusschneider: https://github.com/deegree/deegree3/pull/303
(15:30:17) markusschneider: +1
(15:30:25) StephanR: +1
(15:30:29) copierrj: +1
(15:30:57) markusschneider: +3. Merging
(15:31:26) markusschneider: https://github.com/deegree/deegree3/pull/302
(15:31:27) markusschneider: +1
(15:31:31) markusschneider: same as 3.4 one
(15:31:34) copierrj: +1
(15:31:43) StephanR: +1
(15:31:45) markusschneider: +3. Merging
(15:32:04) markusschneider: https://github.com/deegree/deegree3/pull/305
(15:32:11) markusschneider: +1 (same as 3.4)
(15:32:16) copierrj: +1
(15:32:24) StephanR: +1
(15:32:28) markusschneider: +3. Merging
(15:33:15) markusschneider: ok. thanks, gentemen.
(15:33:18) markusschneider: gentlemen
(15:33:26) markusschneider: 9 pull request remaining.
(15:33:45) markusschneider: i guess that's it.
(15:33:52) copierrj: ok
(15:34:05) StephanR: k
(15:34:11) markusschneider: see you
(15:34:15) copierrj: cu
(15:34:18) StephanR: cu